Makefile: Install and library targets and configurable BUILDDIR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zuiderkwast
commented
Nov 2, 2023
•
zuiderkwast
commented
- Configurable BUILDDIR
- Add install and library targets
- Remove unnecessary variables
bjosv
reviewed
Nov 2, 2023
zuiderkwast
force-pushed
the
lib-and-install-targets
branch
from
9f3bf73
to
27b2064
Compare
zuiderkwast
changed the title
bjosv
reviewed
Nov 6, 2023
There was a problem hiding this comment.
WDYT about renaming SOLIBNAME to LIBNAME, and SOLIBNAME to LIBNAME?
i.e
LIBNAME = liburl_parser
SONAME ?= $(LIBNAME).$(SOEXT).$(SOMAJOR).$(SOMINOR)
SOLIBNAME= $(LIBNAME).$(SOEXT).$(SOMAJOR).$(SOMINOR).$(SOREV)
Then the LIBNAME can additionally be used for the static library.. or maybe we divert to much from the original then?
Yes we can. It makes sense.
Yes, that's why i didn't do the change. But it doesn't matter much. It's more important than the C code is as close as possible to the original. I'll do the change. |
|
Looks better? Do you want a variable for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.